This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Allow warnings #2627
Merged
Allow warnings #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
the
A2-insubstantial
stanislav-tkach
approved these changes
May 20, 2019
Contributor
stanislav-tkach
left a comment
stanislav-tkach
left a comment
There was a problem hiding this comment.
I have mixed feelings about that, but it is really inconvenient without a fixed rust version.
Demi-Marie
approved these changes
May 20, 2019
Contributor
Demi-Marie
left a comment
Demi-Marie
left a comment
There was a problem hiding this comment.
Looks good to me!
I often turn on #![forbid(warnings)] during development, but you are correct that it should be omitted from production code.
gavofyork
added a commit
that referenced
this pull request
May 22, 2019
This reverts commit c52d164.
gavofyork
added a commit
that referenced
this pull request
May 22, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
This reverts commit c52d164.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denying warnings is a bad good-idea. New versions of Rust almost always introduce new warnings, be it deprecated functions or new lints. For example a new version of Rust may decide that it's no longer necessary to explicitly put lifetimes at certain locations, and emit a warning if you do.
It has personally happened to me often enough in the past that I now religiously remove all the
forbid(warnings)that I stumble upon.Forbidding warnings also paradoxically leads to silencing warnings, such as with the
allow(deprecated)that I removed in this PR as well.